Skip to content

fix: correct harness path and next steps in create summary#1099

Merged
notgitika merged 2 commits intopreviewfrom
fix/harness-create-display-path
May 4, 2026
Merged

fix: correct harness path and next steps in create summary#1099
notgitika merged 2 commits intopreviewfrom
fix/harness-create-display-path

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

@notgitika notgitika commented May 4, 2026 •
edited
Loading

Summary

Two bugs in the create flow completion screen for harnesses:

  1. Wrong path in "Created:" tree: Showed harness/<name>/ but harnesses are created under app/<name>/. Fixed in both buildExitMessage (CLI text output) and CreatedSummary (TUI component).

  2. Missing cd instruction: The non-interactive (CLI) completion showed "Next: Run agentcore deploy" without telling the user to cd into the project first, causing "No agentcore project found" when they follow the instruction. Replaced with explicit cd <project> + agentcore instructions, matching the buildExitMessage format.

Changes

  • src/cli/tui/screens/create/CreateScreen.tsx — 1 file, +19/-41 lines
    • harness/ → app/ in both buildExitMessage and CreatedSummary
    • Replaced NextSteps component in the non-interactive branch with cd + agentcore instructions
    • Removed unused NextSteps/NextStep imports, getCreateNextSteps function, and path.join import

Test plan

  • npm run typecheck passes
  • npx eslint on changed file passes (0 errors, 0 warnings)
  • Manual: run agentcore create, pick harness, verify "Created:" shows app/<name>/ and completion says cd <project> then agentcore

@notgitika
fix: correct harness path display and add cd instruction in create su…
8e8a595 
…mmary

Two bugs in the create flow completion screen:

1. The "Created:" tree showed harness path as harness/<name>/ but
   harnesses are actually created under app/<name>/. Fixed in both
   buildExitMessage (CLI output) and CreatedSummary (TUI component).

2. The non-interactive (CLI) completion screen showed
   "Next: Run agentcore deploy" without telling the user to cd into the
   project directory first, causing "No agentcore project found" errors.
   Replaced with explicit "cd <project>" + "agentcore" instructions,
   matching the buildExitMessage output.
@notgitika notgitika requested a review from a team May 4, 2026 01:12
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@agentcore-cli-automation
Copy link
Copy Markdown

agentcore-cli-automation commented May 4, 2026

Reviewed the changes — LGTM.

The → display fix is consistent with where harnesses are actually created (verified in HarnessPrimitive.ts:213, create.test.ts:219, and command.tsx:116). Both buildExitMessage (used as the TUI exit message in App.tsx's interactive path) and the inline non-interactive cd instructions now correctly guide the user into the project before running agentcore.

One very minor nit (non-blocking): NextCommand, NavigateParams, and the onNavigate prop in CreateScreenProps are now effectively dead (the handler is discarded as _onNavigate, and App.tsx's onNavigate callback that does process.chdir is no longer reachable). If you want a follow-up cleanup, the prop and types could be dropped from CreateScreen and the onNavigate={...} block removed from App.tsx. Not a blocker for this PR.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 4, 2026
@notgitika
fix: simplify non-interactive completion rendering
210a75f 
Remove unnecessary Box nesting from the cd instructions. Both
interactive and non-interactive paths now share the success message.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 43.36% 9866 / 22752
🔵 Statements 42.64% 10480 / 24576
🔵 Functions 40.39% 1666 / 4124
🔵 Branches 39.96% 6352 / 15895
Generated in workflow #2344 for commit 210a75f by the Vitest Coverage Report Action

@notgitika notgitika merged commit a47bfa9 into preview May 4, 2026
15 checks passed
@notgitika notgitika deleted the fix/harness-create-display-path branch May 4, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jariy17 jariy17 jariy17 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@notgitika @agentcore-cli-automation @jariy17